feat: add 'dom-ready' event to WebFrameMain #30801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
fix: test failing possibly caused by lazy loaded iframes? refactor: move frame-dom-ready event into WebFrameMain test: new WebFrameMain dom-ready event refactor: return bool refactor: add gin_helper::AccessorValue for gin accessor conversion refactor: call methods directly from electron:WebContents Writing static method boilerplate isn't fun feat: add WebFrameMain 'destroyed' event Update shell/common/gin_converters/frame_converter.cc Co-authored-by: Jeremy Rose <nornagon@nornagon.net> refactor: use persistent handle for rfh obj template docs: when the WebFrameMain 'destroyed' event can occur refactor: use dcheck and 'As' instead of 'Cast' chore: add type checking to internal fields refactor: add conditional for internal field count refactor: removed 'destroyed event and isDestroyed() This may be revisited at a later time. test: frame-created event
|old_host| may be nullptr if the previous RFH was shutdown.
5 tasks
trop
bot
added
15-x-y
backport
MarshallOfSound
approved these changes
Sep 1, 2021
codebytere
deleted the
trop/15-x-y-bp-feat-add-dom-ready-event-to-webframemain-1630534889429
branch
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #29290
See that PR for details.
Notes:
WebFrameMainwhich emits when the frame's document is ready.WebContentswhich emits when a frame is created in the page.