Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add webContents.fromDevToolsTargetId() #30732

Merged
merged 2 commits into from Aug 30, 2021
Merged

feat: add webContents.fromDevToolsTargetId() #30732

merged 2 commits into from Aug 30, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 27, 2021

Backport of #29399

See that PR for details.

Notes: Added webContents.fromDevToolsTargetId(targetId) to lookup a WebContents instance from an associated Chrome DevTools Protocol TargetID.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 27, 2021
@trop trop bot mentioned this pull request Aug 27, 2021
Merged
5 tasks
@trop trop bot added 14-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Aug 27, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 27, 2021
codebytere
codebytere approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkleinsc
Copy link
Contributor

Merging as CI failures are known flakes.

@jkleinsc jkleinsc merged commit 3cdb74e into 14-x-y Aug 30, 2021
@jkleinsc jkleinsc deleted the trop/14-x-y-bp-feat-add-webcontents-fromdevtoolstargetid--1630098108157 branch August 30, 2021 16:43
@release-clerk
Copy link

release-clerk bot commented Aug 30, 2021

Release Notes Persisted

Added webContents.fromDevToolsTargetId(targetId) to lookup a WebContents instance from an associated Chrome DevTools Protocol TargetID.

@jkleinsc jkleinsc added semver/minor backwards-compatible functionality and removed semver/minor backwards-compatible functionality labels Aug 30, 2021
@mxschmitt mxschmitt mentioned this pull request Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
14-x-y backport/approved ✅ backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jkleinsc @codebytere @VerteDinde @samuelmaddock