New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(electron): browser window ids out of sync #8759
fix(electron): browser window ids out of sync #8759
Conversation
@samuelmaddock Could you please rebase this (there are merge conflicts) so I can trigger the bots? I've also undrafted for the bots to pick this up. |
2de3897
to
53581d2
Compare
f83851a
to
23ad986
Compare
Changes have been rebased and now targets Electron v12.2.0 which is the minimum version including the new |
TS error after upgrading Electron:
It seems like |
@samuelmaddock we can split it in two. I'll take care that #8837 lands soon which does exactly that, then your PR should pass. |
I landed the roll, you can rebase this PR and we will merge. |
23ad986
to
20e9f6f
Compare
For the record: After this patch the minimum required versions of Electron are:
|
fixes #6760
fixes #6748
Playwright's Electron implementation is keeping track of
BrowserWindow
IDs itself which has issues that cause it to go out of sync. This has been a blocker for complex Electron apps using multiple windows orBrowserView
s.I've introduced a new API to Electron which will allow using the DevTools Target ID as a stable lookup identifier for
WebContents
: electron/electron#29399This PR is set as a draft to receive feedback and wait for Electron changes to be merged and released:
v12.2.0 has been released now with these changes. This PR upgrade to it since it's the minimum supported version.