Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: persist BrowserView background color when bounds offscreen #30540

Merged
merged 1 commit into from Aug 18, 2021
Merged

fix: persist BrowserView background color when bounds offscreen #30540

merged 1 commit into from Aug 18, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 16, 2021

Backport of #30510

See that PR for details.

Notes: Fixed an issue where background color would not be correctly applied to BrowserViews on Windows when either the x or y coordinate is negative (off-screen).

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 16, 2021
@trop trop bot requested a review from codebytere August 16, 2021 10:27
@trop trop bot mentioned this pull request Aug 16, 2021
Merged
3 tasks
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Aug 16, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 16, 2021
@zcbenz zcbenz merged commit f616c85 into 13-x-y Aug 18, 2021
@zcbenz zcbenz deleted the trop/13-x-y-bp-fix-persist-browserview-background-color-when-bounds-offscreen-1629109632909 branch August 18, 2021 23:40
@release-clerk
Copy link

release-clerk bot commented Aug 18, 2021

Release Notes Persisted

Fixed an issue where background color would not be correctly applied to BrowserViews on Windows when either the x or y coordinate is negative (off-screen).

@andreasdj andreasdj mentioned this pull request Oct 21, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @codebytere