fix: persist BrowserView background color when bounds offscreen #30510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
approved these changes
Aug 12, 2021
zcbenz
approved these changes
Aug 13, 2021
|
It's great, very grateful👍 👍 👍 👍 👍 👍 |
|
failure is a flake |
|
Release Notes Persisted
|
This was referenced Aug 16, 2021
|
I have automatically backported this PR to "13-x-y", please check out #30540 |
|
I have automatically backported this PR to "14-x-y", please check out #30541 |
|
I have automatically backported this PR to "15-x-y", please check out #30542 |
miniak
pushed a commit
that referenced
this pull request
Aug 18, 2021
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
andreasdj
pushed a commit
to andreasdj/electron
that referenced
this pull request
Feb 4, 2022
Reverting change introduced in PR: electron#30510
3 tasks
zcbenz
pushed a commit
that referenced
this pull request
Mar 23, 2022
Reverting change introduced in PR: #30510 Co-authored-by: Andreas Johansson <aj3621@tobii.com>
trop bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
Reverting change introduced in PR: #30510
trop bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
Reverting change introduced in PR: #30510
codebytere
pushed a commit
that referenced
this pull request
Mar 23, 2022
Reverting change introduced in PR: #30510 Co-authored-by: Andreas Johansson <aj3621@tobii.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 23, 2022
Reverting change introduced in PR: #30510 Co-authored-by: Andreas Johansson <aj3621@tobii.com>
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
…tron#32747) Reverting change introduced in PR: electron#30510 Co-authored-by: Andreas Johansson <aj3621@tobii.com>
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…tron#32747) Reverting change introduced in PR: electron#30510 Co-authored-by: Andreas Johansson <aj3621@tobii.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #29778.
Fixes an issue where background color would not be correctly applied to
BrowserViewson Windows when either thexorycoordinate is negative (off-screen).This was happening because
view::Viewswas trying to paint the whole content bounds instead of the visible bounds, which caused issues because when part of the bounds are offscreen the compositor overrides and paints them white. This fixes that by painting the visible bounds.Before:
After:
Tested with https://gist.github.com/712a2fde2757736c9dbf6c3e7e0aa18b.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where background color would not be correctly applied to
BrowserViewson Windows when either thexorycoordinate is negative (off-screen).