chore: bump chromium to 95.0.4612.5 (main) #30503

electron-roller · 2021-08-11T21:12:51Z

Updating Chromium to 95.0.4612.5.

See all changes in 94.0.4590.2..95.0.4612.5

Notes: Updated Chromium to 95.0.4612.5.

shell/browser/native_window_mac.mm

deepak1556 · 2021-08-18T21:45:29Z

patches/chromium/printing.patch

+     return;
+   }
+
+#if 0


We are disabling pdf rasterization

electron/shell/browser/api/electron_api_web_contents.cc

Line 2548 in cbeae20

settings.SetBoolKey(printing::kSettingRasterizePdf, false);

, the change follows suit with it.

deepak1556 · 2021-08-18T21:48:35Z

docs/api/cookies.md

@@ -93,7 +93,7 @@ the response.
  * `domain` String (optional) - The domain of the cookie; this will be normalized with a preceding dot so that it's also valid for subdomains. Empty by default if omitted.
  * `path` String (optional) - The path of the cookie. Empty by default if omitted.
  * `secure` Boolean (optional) - Whether the cookie should be marked as Secure. Defaults to
-    false.
+    false unless [Same Site=None](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite#samesitenone_requires_secure) attribute is used.


Should we signal this as breaking change in 14.x.y, considering 15-x-y will get this behavior ?

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3076040

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3069287

…RemoveKey() Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2297212 Also: https://chromium-review.googlesource.com/c/chromium/src/+/3060296

…to a file. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3082756 > this CL intentionally changes the name of the parameter > in the network context parameters and the order of the constructor > parameters to ensure all callers update their code to pass a full > file path rather than a path to a directory. The 'path' in this diff is already an absolute path, coming from `CHECK(base::PathService::Get(chrome::DIR_USER_DATA, &path_));` at https://github.com/electron/electron/blob/08ff1c2cbf73c8cfe6bca7976e3eddc3626678db/shell/browser/electron_browser_context.cc#L126

Missed one.

…nsion Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2999884 (example of replacing GetStringWithoutPathExpansion() w/FindStringKey()) Also: https://chromium-review.googlesource.com/c/chromium/src/+/3060296 (removal of DictionaryValue::GetStringWithoutPathExpansion)

Dependency was missed in cbeae20

deepak1556 · 2021-08-23T05:32:17Z

patches/chromium/add_gin_wrappable_crash_key.patch

+   }
+
+  if (!is_mas_build) {
+    public_deps += [ "//components/crash/core/common:crash_key" ]


/cc @VerteDinde , might want to cherry-pick this to older branches..

Thank you! 🙂 Will do that now

https://chromium-review.googlesource.com/c/codecs/libgav1/+/3108669

This reverts commit 7ed3132.

This reverts commit 084a490.

deepak1556 · 2021-08-23T22:12:19Z

patches/chromium/revert_roll_clang_llvmorg-14-init-1002-gb5e470aa-1.patch

+Subject: Revert "Roll clang llvmorg-14-init-1002-gb5e470aa-1 :
+ llvmorg-14-init-1380-gee659383-1"
+
+This reverts commit 65172c258c45f5bc22f2018884d013b8d11f4b26.


@jkleinsc is there a corresponding upstream issue ?

I couldn't find one.

ckerr · 2021-08-23T22:15:32Z

docs/api/cookies.md

@@ -93,7 +93,7 @@ the response.
  * `domain` String (optional) - The domain of the cookie; this will be normalized with a preceding dot so that it's also valid for subdomains. Empty by default if omitted.
  * `path` String (optional) - The path of the cookie. Empty by default if omitted.
  * `secure` Boolean (optional) - Whether the cookie should be marked as Secure. Defaults to
-    false.
+    false unless [Same Site=None](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite#samesitenone_requires_secure) attribute is used.


shell/browser/native_window_mac.mm

nornagon · 2021-08-23T22:46:06Z

patches/chromium/feat_expose_raw_response_headers_from_urlloader.patch

+   response_ = network::mojom::URLResponseHead::New();
+   PopulateResourceResponse(url_request_.get(), is_load_timing_enabled_,
+                            options_, response_.get());
+  if (raw_response_headers_ && devtools_request_id()) {


Is devtools_request_id the right way to filter this? Can we add a specific flag instead?

@deepak1556 can you respond to @nornagon's question here? If there is an issue with this, I can followup in #30676.

I was mainly trying to keep the patch as minimal as possible, hence tried to reuse the existing identifier that was added in https://chromium-review.googlesource.com/c/chromium/src/+/2856099.

But yeah this definitely isn't the one for readability, if we are fine with touching a couple more files as part of the patch then we can bring back the report_raw_headers boolean.

nornagon · 2021-08-23T22:47:09Z

shell/browser/api/electron_api_session.cc

@@ -912,7 +912,7 @@ static void StartPreconnectOnUI(ElectronBrowserContext* browser_context,
                                int num_sockets_to_preconnect) {
  std::vector<predictors::PreconnectRequest> requests = {
      {url::Origin::Create(url), num_sockets_to_preconnect,
-       net::NetworkIsolationKey()}};
+       net::NetworkIsolationKey::CreateTransient()}};


Hm, is this correct? I don't know much about network isolation but it seems like preconnect might respond poorly to having a different network isolation key between the preconnect and the connect?

@deepak1556 can you respond to @nornagon's question here? If there is an issue with this, I can followup in #30676.

Yeah you are right, I should have created the isolation key from the origin of preconnect url. The current implementation will definitely disallow sharing the sockets created in the preconnect step.

patches/chromium/remove_--no-untrusted-code-mitigations_from_content_and_gin.patch

nornagon · 2021-08-23T22:49:31Z

build/args/all.gn

+
+# TODO(deepak1556): remove once https://bugs.chromium.org/p/chromium/issues/detail?id=1241610
+# is fixed.
+enable_blink_heap_use_v8_oilpan = false


terrifying, is there some way we can ensure we don't release with this disabled?

Looks like https://chromium.googlesource.com/v8/v8/+/4853c3ad81b178811814e7ab8fc28ecafe911e57 addresses the issue and should hit the chromium roll tomorrow. I'll check then and see if I can re-enable in #30676

is there some way we can ensure we don't release with this disabled?

Can you expand on why it is bad to disable this flag ? I see that this feature was only enabled recently https://chromium-review.googlesource.com/c/chromium/src/+/3089152, so shouldn't the old code path be still fine to use ?

But it is great that upstream fixed the regression as well, we can turn it on again in the next roll.

release-clerk · 2021-08-24T00:52:19Z

Release Notes Persisted

Updated Chromium to 95.0.4612.5.

nornagon · 2021-08-24T17:41:09Z

@jkleinsc it looks like this was merged despite a bunch of outstanding comments from me, was that intentional?

jkleinsc · 2021-08-24T17:43:23Z

@nornagon yeah... I wanted to get the roll moving again with a green build. I'm happy to address outstanding issues in #30676.

* chore: bump chromium in DEPS to 94.0.4604.0 * build: 3-way merge of chromium patches * chore: bump chromium in DEPS to 94.0.4605.0 * build: 3-way merge of chromium patches * 3076040: Reland Remove delete_children RemoveAllChildViews arg Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3076040 * 3069287: Remove the remaining uses and delete the deprecated API Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3069287 * 2297212: Replace RemoveWithoutPathExpansion(.*, nullptr) with Value::RemoveKey() Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2297212 Also: https://chromium-review.googlesource.com/c/chromium/src/+/3060296 * 3082756: Change transport_security_persister_path param to be a path to a file. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3082756 > this CL intentionally changes the name of the parameter > in the network context parameters and the order of the constructor > parameters to ensure all callers update their code to pass a full > file path rather than a path to a directory. The 'path' in this diff is already an absolute path, coming from `CHECK(base::PathService::Get(chrome::DIR_USER_DATA, &path_));` at https://github.com/electron/electron/blob/08ff1c2cbf73c8cfe6bca7976e3eddc3626678db/shell/browser/electron_browser_context.cc#L126 * iwyu: network::mojom::HttpRawHeaderPair * fixup! 3076040: Reland Remove delete_children RemoveAllChildViews arg Missed one. * 2999884: CodeHealth: Remove DictionaryValue::GetStringWithoutPathExpansion Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2999884 (example of replacing GetStringWithoutPathExpansion() w/FindStringKey()) Also: https://chromium-review.googlesource.com/c/chromium/src/+/3060296 (removal of DictionaryValue::GetStringWithoutPathExpansion) * 3059260: Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3059260 We had both of these in a 'disable_features' list. Since these feature have been removed upstream, remove them from our disable list, too. IMPORTANT: this commit should not be backported to older branches that still have these features, because doing so would un-disable them. * 2920890: Load reroute_info from download in-progress and history db back into DownloadItem. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2920890 * 3039323: [Clipboard API] Clipboard Custom Formats implementation Part 5. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3039323 * chore: bump chromium in DEPS to 94.0.4606.0 * 3084502: Add a new PrintRasterizePdfDpi policy. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3084502 * chore: update patches * chore: bump chromium in DEPS to 94.0.4606.3 * chore: bump chromium in DEPS to 95.0.4608.0 * chore: bump chromium in DEPS to 95.0.4609.0 * [DevTools] Remove report_raw_headers from network::ResourceRequest https://chromium-review.googlesource.com/c/chromium/src/+/2856099 * Remove content::WebContentsObserver::OnInterfaceRequestFromFrame https://chromium-review.googlesource.com/c/chromium/src/+/3092665 * Disable kDesktopCaptureMacV2 https://chromium-review.googlesource.com/c/chromium/src/+/3069272 * Add a new PrintRasterizePdfDpi policy. https://chromium-review.googlesource.com/c/chromium/src/+/3084502 * chore: update patches * chore: bump chromium in DEPS to 95.0.4609.3 * disable `use_lld` for macos * chore: update patches * Linux: use chrome_crashpad_handler instead of crashpad_handler https://chromium-review.googlesource.com/c/chromium/src/+/3054290 * chore: fix lint * Revert "[DevTools] Remove report_raw_headers from network::ResourceRequest" This reverts commit 28f4da1. * [DevTools] Remove report_raw_headers from network::ResourceRequest (Attempt electron#2) https://chromium-review.googlesource.com/c/chromium/src/+/2856099 * DCHECK that predictor always has a non-empty NetworkIsolationKey. https://chromium-review.googlesource.com/c/chromium/src/+/3067698 * Remove --no-untrusted-code-mitigations from //content and //gin https://chromium-review.googlesource.com/c/chromium/src/+/3096585 * fixup! Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure https://chromium-review.googlesource.com/c/chromium/src/+/3059260 * fixup! Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure * Convert PrintManager to RenderFrameHostReceiverSet. https://chromium-review.googlesource.com/c/chromium/src/+/3072019 * chore: bump chromium in DEPS to 95.0.4612.5 * chore: disable v8 oilpan * [Compiler] Remove untrusted code mitigations. https://chromium-review.googlesource.com/c/v8/v8/+/3045704 * Remove most FTP logic from services/network. https://chromium-review.googlesource.com/c/chromium/src/+/3076119 * Rename scale_factor.h -> resource_scale_factor.h https://chromium-review.googlesource.com/c/chromium/src/+/3057113 * [GURL -> SiteForCookies] extensions/ https://chromium-review.googlesource.com/c/chromium/src/+/3100825 * breadcrumbs: add desktop entry point https://chromium-review.googlesource.com/c/chromium/src/+/3021746 * Move args_ to private in ExtensionFunction https://chromium-review.googlesource.com/c/chromium/src/+/3076261 * chore: iwyu * fixup! Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure * Disable kDesktopCaptureMacV2 https://chromium-review.googlesource.com/c/chromium/src/+/3069272 * fixup! [Compiler] Remove untrusted code mitigations. * fixup! Disable kDesktopCaptureMacV2 * Revert "chore: disable v8 oilpan" This reverts commit 5d255cf. * Reland "chore: disable v8 oilpan" This reverts commit 1c25276. The previous revert was to test on which platforms did the heapsnapshot test actually fail. * [Clipboard API] Clipboard Custom Formats implementation Part 5. https://chromium-review.googlesource.com/c/chromium/src/+/3039323 * Convert ExtensionFrameHost to RenderFrameHostReceiverSet. https://chromium-review.googlesource.com/c/chromium/src/+/3063358 * Convert PDFWebContentsHelper to RenderFrameHostReceiverSet. https://chromium-review.googlesource.com/c/chromium/src/+/3049751 * [Underscore Migration] Migrate ui/legacy https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3093160 * chore: remove unknown permission error * chore: fix lint * chore: ignore -Wunreachable-code-return for node deps/ * fixup! chore: ignore -Wunreachable-code-return for node deps/ * fix: windows build * fix: build dependency Dependency was missed in cbeae20 * 3108669: arm,dsp: Fix 8bpp Dct64_NEON(). https://chromium-review.googlesource.com/c/codecs/libgav1/+/3108669 * chore: revert libgav1 roll * Revert "3108669: arm,dsp: Fix 8bpp Dct64_NEON()." This reverts commit 7ed3132. * Revert "chore: revert libgav1 roll" This reverts commit 084a490. * chore: revert clang roll * chore: Fix -Wunreachable-code-aggressive warnings in arm and arm64 code Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: mlaurencin <mlaurencin@electronjs.org> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

electron-roller bot requested a review from a team as a code owner August 11, 2021 21:12

electron-roller bot added backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Aug 11, 2021

electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Aug 11, 2021

electron-roller bot changed the title ~~chore: bump chromium to 94.0.4604.0 (main)~~ chore: bump chromium to 94.0.4605.0 (main) Aug 12, 2021

electron-roller bot changed the title ~~chore: bump chromium to 94.0.4605.0 (main)~~ chore: bump chromium to 94.0.4606.0 (main) Aug 13, 2021

electron-roller bot changed the title ~~chore: bump chromium to 94.0.4606.0 (main)~~ chore: bump chromium to 94.0.4606.3 (main) Aug 14, 2021

electron-roller bot changed the title ~~chore: bump chromium to 94.0.4606.3 (main)~~ chore: bump chromium to 95.0.4608.0 (main) Aug 15, 2021

electron-roller bot changed the title ~~chore: bump chromium to 95.0.4608.0 (main)~~ chore: bump chromium to 95.0.4609.0 (main) Aug 16, 2021

electron-roller bot changed the title ~~chore: bump chromium to 95.0.4609.0 (main)~~ chore: bump chromium to 95.0.4609.3 (main) Aug 17, 2021

deepak1556 force-pushed the roller/chromium/main branch 2 times, most recently from ba4f18d to 5bac012 Compare August 17, 2021 20:09

deepak1556 added no-backport roller/pause labels Aug 17, 2021

deepak1556 reviewed Aug 18, 2021

View reviewed changes

shell/browser/native_window_mac.mm Outdated Show resolved Hide resolved

deepak1556 reviewed Aug 18, 2021

View reviewed changes

deepak1556 changed the title ~~chore: bump chromium to 95.0.4609.3 (main)~~ chore: bump chromium to 95.0.4612.5 (main) Aug 19, 2021

electron-roller bot and others added 11 commits August 20, 2021 16:14

chore: bump chromium in DEPS to 94.0.4604.0

f697737

build: 3-way merge of chromium patches

622ebf6

chore: bump chromium in DEPS to 94.0.4605.0

d56f099

build: 3-way merge of chromium patches

5ee3eca

3076040: Reland Remove delete_children RemoveAllChildViews arg

9add067

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3076040

3069287: Remove the remaining uses and delete the deprecated API

0cd4054

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3069287

2297212: Replace RemoveWithoutPathExpansion(.*, nullptr) with Value::…

a4ac16c

…RemoveKey() Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2297212 Also: https://chromium-review.googlesource.com/c/chromium/src/+/3060296

iwyu: network::mojom::HttpRawHeaderPair

13f2301

fixup! 3076040: Reland Remove delete_children RemoveAllChildViews arg

f4d6672

Missed one.

deepak1556 added 2 commits August 20, 2021 16:14

chore: fix lint

b4ea757

chore: ignore -Wunreachable-code-return for node deps/

78669f8

deepak1556 force-pushed the roller/chromium/main branch from 0685f21 to 78669f8 Compare August 20, 2021 23:24

deepak1556 added 2 commits August 20, 2021 17:37

fixup! chore: ignore -Wunreachable-code-return for node deps/

7da5764

fix: windows build

dbb9af3

deepak1556 force-pushed the roller/chromium/main branch from 29834cf to dbb9af3 Compare August 21, 2021 06:41

fix: build dependency

4cfc729

Dependency was missed in cbeae20

deepak1556 reviewed Aug 23, 2021

View reviewed changes

jkleinsc added 6 commits August 23, 2021 10:53

3108669: arm,dsp: Fix 8bpp Dct64_NEON().

7ed3132

https://chromium-review.googlesource.com/c/codecs/libgav1/+/3108669

chore: revert libgav1 roll

084a490

Revert "3108669: arm,dsp: Fix 8bpp Dct64_NEON()."

419a35a

This reverts commit 7ed3132.

Revert "chore: revert libgav1 roll"

99f921e

This reverts commit 084a490.

chore: revert clang roll

6179981

chore: Fix -Wunreachable-code-aggressive warnings in arm and arm64 code

058354c

jkleinsc approved these changes Aug 23, 2021

View reviewed changes

deepak1556 reviewed Aug 23, 2021

View reviewed changes

ckerr approved these changes Aug 23, 2021

View reviewed changes

VerteDinde approved these changes Aug 23, 2021

View reviewed changes

nornagon reviewed Aug 23, 2021

View reviewed changes

jkleinsc merged commit 5513e66 into main Aug 24, 2021

jkleinsc deleted the roller/chromium/main branch August 24, 2021 00:52

jkleinsc mentioned this pull request Aug 24, 2021

chore: Match upstream for kWindowCaptureMacV2 #30682

Closed

commit-lint bot mentioned this pull request Aug 25, 2021

[pull] main from electron:main Blaquez-home/electron#3

Open

This was referenced Sep 4, 2021

chore: follow-up to roll 95.0.4612.5 #30835

Merged

Enable SameSite-by-default feature once 11-x-y is branched #24225

Closed

fix: suppress insecure resource warning for more local hostnames #30885

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump chromium to 95.0.4612.5 (main) #30503

chore: bump chromium to 95.0.4612.5 (main) #30503

electron-roller bot commented Aug 11, 2021 •

edited by deepak1556

deepak1556 Aug 18, 2021

deepak1556 Aug 18, 2021

ckerr Aug 23, 2021

deepak1556 Aug 23, 2021

VerteDinde Aug 23, 2021

deepak1556 Aug 23, 2021

jkleinsc Aug 24, 2021

ckerr Aug 23, 2021

nornagon Aug 23, 2021

jkleinsc Aug 24, 2021

deepak1556 Aug 25, 2021

nornagon Aug 23, 2021

jkleinsc Aug 24, 2021

deepak1556 Aug 25, 2021

nornagon Aug 23, 2021

jkleinsc Aug 24, 2021

deepak1556 Aug 25, 2021

release-clerk bot commented Aug 24, 2021

nornagon commented Aug 24, 2021

jkleinsc commented Aug 24, 2021

+                   return;
+                 }
+              +#if 0

chore: bump chromium to 95.0.4612.5 (main) #30503

chore: bump chromium to 95.0.4612.5 (main) #30503

Conversation

electron-roller bot commented Aug 11, 2021 • edited by deepak1556

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

release-clerk bot commented Aug 24, 2021

nornagon commented Aug 24, 2021

jkleinsc commented Aug 24, 2021

electron-roller bot commented Aug 11, 2021 •

edited by deepak1556