Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Match upstream for kWindowCaptureMacV2 #30682

Closed
jkleinsc opened this issue Aug 24, 2021 · 7 comments
Closed

chore: Match upstream for kWindowCaptureMacV2 #30682

jkleinsc opened this issue Aug 24, 2021 · 7 comments
Assignees
Labels
15-x-y stale upgrade-follow-up Stuff left to do after a Chromium upgrade.
Projects

Comments

@jkleinsc
Copy link
Contributor

#30503 added a patch to disable kWindowCaptureMacV2.

#30507 incorrectly stated that https://chromium-review.googlesource.com/c/chromium/src/+/3069272 disabled this flag, but that CL only disabled DesktopCaptureMacV2, but kept WindowCaptureMacV2 enabled.

The patch was added to make sure that the test/issue added in #30503 still passed, but we should find a way to re-enable the flag to match upstream.

@jkleinsc jkleinsc added the upgrade-follow-up Stuff left to do after a Chromium upgrade. label Aug 24, 2021
@nornagon nornagon added 15-x-y blocks-release Releases shouldn't go out without this fix labels Aug 24, 2021
@VerteDinde VerteDinde added this to Unsorted Issues in 15-x-y Aug 25, 2021
@VerteDinde VerteDinde self-assigned this Aug 25, 2021
@deepak1556
Copy link
Member

#30503 (comment) for additional context on the bug.

@MarshallOfSound MarshallOfSound moved this from Unsorted Issues to Does Not Block Stable in 15-x-y Sep 1, 2021
@MarshallOfSound MarshallOfSound removed the blocks-release Releases shouldn't go out without this fix label Sep 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Oct 5, 2022
@jkleinsc jkleinsc removed the stale label Oct 5, 2022
@jkleinsc
Copy link
Contributor Author

jkleinsc commented Oct 5, 2022

This is still an issue that should be addressed: https://github.com/electron/electron/blob/main/patches/chromium/desktop_media_list.patch#L92

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Jan 10, 2023
@jkleinsc jkleinsc removed the stale label Jan 17, 2023
@jkleinsc
Copy link
Contributor Author

This is still an issue that should be addressed: https://github.com/electron/electron/blob/main/patches/chromium/desktop_media_list.patch#L92

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Apr 18, 2023
@github-actions
Copy link
Contributor

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15-x-y stale upgrade-follow-up Stuff left to do after a Chromium upgrade.
Projects
15-x-y
Does Not Block Stable
Development

No branches or pull requests

5 participants