New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Match upstream for kWindowCaptureMacV2
#30682
Comments
#30503 (comment) for additional context on the bug. |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
This is still an issue that should be addressed: https://github.com/electron/electron/blob/main/patches/chromium/desktop_media_list.patch#L92 |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
This is still an issue that should be addressed: https://github.com/electron/electron/blob/main/patches/chromium/desktop_media_list.patch#L92 |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue. |
#30503 added a patch to disable kWindowCaptureMacV2.
#30507 incorrectly stated that https://chromium-review.googlesource.com/c/chromium/src/+/3069272 disabled this flag, but that CL only disabled DesktopCaptureMacV2, but kept WindowCaptureMacV2 enabled.
The patch was added to make sure that the test/issue added in #30503 still passed, but we should find a way to re-enable the flag to match upstream.
The text was updated successfully, but these errors were encountered: