Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose des-ede3 cipher #30453

Merged
merged 1 commit into from Aug 12, 2021
Merged

feat: expose des-ede3 cipher #30453

merged 1 commit into from Aug 12, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 9, 2021 •
edited by codebytere

Closes #30428

Backport of #27897

See that PR for details.

Notes: Added support for the des-ede3 cipher in node crypto.

@trop trop bot requested a review from a team as a code owner August 9, 2021 08:28
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 9, 2021
@trop trop bot requested a review from nornagon August 9, 2021 08:28
@trop trop bot mentioned this pull request Aug 9, 2021
Merged
2 tasks
@trop trop bot added 13-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Aug 9, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 9, 2021
@codebytere codebytere mentioned this pull request Aug 9, 2021
Closed
3 tasks
MarshallOfSound
MarshallOfSound approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @electron/wg-releases

@nornagon nornagon merged commit 2716a25 into 13-x-y Aug 12, 2021
@nornagon nornagon deleted the trop/13-x-y-bp-feat-expose-des-ede3-cipher-1628497702654 branch August 12, 2021 18:48
@release-clerk
Copy link

release-clerk bot commented Aug 12, 2021

Release Notes Persisted

Added support for the des-ede3 cipher in node crypto.

@gnarea gnarea mentioned this pull request Nov 17, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
13-x-y backport/requested 🗳 backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @MarshallOfSound