Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: des-ede3 cipher missing from Electron v13 #30428

Closed
3 tasks done
ghost opened this issue Aug 5, 2021 · 2 comments
Closed
3 tasks done

[Bug]: des-ede3 cipher missing from Electron v13 #30428

ghost opened this issue Aug 5, 2021 · 2 comments
Labels
13-x-y bug 🪲 bug/regression ↩️ A new version of Electron broke something status/confirmed A maintainer reproduced the bug or agreed with the feature

Comments

@ghost
Copy link

ghost commented Aug 5, 2021

Preflight Checklist

Electron Version

13.1.8

What operating system are you using?

macOS

Operating System Version

Catalina (10.15.7)

What arch are you using?

x64

Last Known Working Electron version

12.0.15

Expected Behavior

Cipher des-ede3 should be supported. It was working on Electron v12.0.15 and I couldn't find any announcement of it being deprecated.

Oddly, this file exists: https://github.com/electron/electron/blob/v12.0.16/patches/boringssl/expose_des-ede3.patch, and so does this: https://github.com/electron/electron/blob/main/patches/boringssl/expose_des-ede3.patch. This one doesn't, though: https://github.com/electron/electron/blob/v13.1.8/patches/boringssl/expose_des-ede3.patch.

It just looks like support for this cipher was introduced sometime during v12.x and never got backported to v13.x.

Actual Behavior

Cipher des-ede3 is not supported anymore. The following code:

import crypto from 'crypto';
...
crypto.createCipheriv('des-ede3', crypto.randomBytes(24), null);

fails with:

Error: Unknown cipher
    at Cipheriv.createCipherBase (internal/crypto/cipher.js:103:19)
    at Cipheriv.createCipherWithIV (internal/crypto/cipher.js:121:20)
    at new Cipheriv (internal/crypto/cipher.js:227:22)
    at Object.createCipheriv (crypto.js:123:10)

Testcase Gist URL

No response

Additional Information

No response

@ghost ghost added the bug 🪲 label Aug 5, 2021
@clavin clavin added 13-x-y bug/regression ↩️ A new version of Electron broke something status/confirmed A maintainer reproduced the bug or agreed with the feature labels Aug 7, 2021
@codebytere
Copy link
Member

Opened a PR: #30453

@codebytere
Copy link
Member

Closed in #30453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13-x-y bug 🪲 bug/regression ↩️ A new version of Electron broke something status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
None yet
Development

No branches or pull requests

2 participants