Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: potential crash on macOS app exit #30138

Merged
merged 1 commit into from Jul 15, 2021
Merged

fix: potential crash on macOS app exit #30138

merged 1 commit into from Jul 15, 2021

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jul 14, 2021

Backport of #29941

See that PR for details.

Notes: Fixes a potential crash when calling app.quit() on macOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 14, 2021
@trop trop bot mentioned this pull request Jul 14, 2021
Merged
3 tasks
@trop trop bot added 12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 14, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 14, 2021
ckerr
ckerr approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, the patch + surrounding text looks identical to #29941 for main? I'm not sure why trop couldn't backport this one

@zcbenz zcbenz merged commit 488fbfe into 12-x-y Jul 15, 2021
@zcbenz zcbenz deleted the miniak/fix-event-monitor-crash-12-x-y branch July 15, 2021 02:42
@release-clerk
Copy link

release-clerk bot commented Jul 15, 2021

Release Notes Persisted

Fixes a potential crash when calling app.quit() on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miniak @ckerr @nornagon @zcbenz @codebytere