fix: potential crash on macOS app exit (#29941) (#30138)

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
electron · Jul 15, 2021 · 488fbfe · 488fbfe
1 parent 705a9a3
commit 488fbfe
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/shell/browser/native_window_mac.mm b/shell/browser/native_window_mac.mm
@@ -498,7 +498,7 @@ void ViewDidMoveToSuperview(NSView* self, SEL _cmd) {
   // Use an NSEvent monitor to listen for the wheel event.
   BOOL __block began = NO;
   wheel_event_monitor_ = [NSEvent
-      addLocalMonitorForEventsMatchingMask:NSScrollWheelMask
+      addLocalMonitorForEventsMatchingMask:NSEventMaskScrollWheel
                                    handler:^(NSEvent* event) {
                                      if ([[event window] windowNumber] !=
                                          [window_ windowNumber])
@@ -539,7 +539,10 @@ void ViewDidMoveToSuperview(NSView* self, SEL _cmd) {
   DCHECK(!IsClosed());
   ui::NativeTheme::GetInstanceForNativeUi()->RemoveObserver(this);
   display::Screen::GetScreen()->RemoveObserver(this);
-  [NSEvent removeMonitor:wheel_event_monitor_];
+  if (wheel_event_monitor_) {
+    [NSEvent removeMonitor:wheel_event_monitor_];
+    wheel_event_monitor_ = nil;
+  }
 }
 
 void NativeWindowMac::RedrawTrafficLights() {