Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double traffic lights on exit fullscreen #30114

Merged
merged 1 commit into from Jul 14, 2021

Conversation

codebytere
Copy link
Member

Description of Change

Closes #30026.

Fixes an issue where the traffic lights would get double-drawn when exiting fullscreen and adding a BrowserView on macOS. In 8bf66f8 the original code did not redraw traffic lights when the window was fullscreened, but this logic did not perisist and then when I merged #29595 this created the issue.

We fix this by not reordering the buttons in the view hierarchy when we're in fullscreen mode.

Tested with https://gist.github.com/45f0a58d69bec2834535e57768363572 and confirmed not to regress #29541.

Checklist

Release Notes

Notes: Fixes an issue where the traffic lights would get double-drawn when exiting fullscreen and adding a BrowserView on macOS.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/13-x-y labels Jul 13, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 13, 2021
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta love one-liners

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 14, 2021
@codebytere
Copy link
Member Author

Failure not relevant.

@codebytere codebytere merged commit 3f38681 into main Jul 14, 2021
@codebytere codebytere deleted the fix-bv-traffic-fullscreen branch July 14, 2021 23:45
@release-clerk
Copy link

release-clerk bot commented Jul 14, 2021

Release Notes Persisted

Fixes an issue where the traffic lights would get double-drawn when exiting fullscreen and adding a BrowserView on macOS.

@trop
Copy link
Contributor

trop bot commented Jul 14, 2021

I have automatically backported this PR to "13-x-y", please check out #30149

@trop
Copy link
Contributor

trop bot commented Jul 14, 2021

I have automatically backported this PR to "14-x-y", please check out #30150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Traffic lights re-appear in fullscreen on macOS
5 participants