New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: double traffic lights on exit fullscreen #30114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotta love one-liners
Failure not relevant. |
Release Notes Persisted
|
I have automatically backported this PR to "13-x-y", please check out #30149 |
I have automatically backported this PR to "14-x-y", please check out #30150 |
Description of Change
Closes #30026.
Fixes an issue where the traffic lights would get double-drawn when exiting fullscreen and adding a
BrowserView
on macOS. In 8bf66f8 the original code did not redraw traffic lights when the window was fullscreened, but this logic did not perisist and then when I merged #29595 this created the issue.We fix this by not reordering the buttons in the view hierarchy when we're in fullscreen mode.
Tested with https://gist.github.com/45f0a58d69bec2834535e57768363572 and confirmed not to regress #29541.
Checklist
npm test
passesRelease Notes
Notes: Fixes an issue where the traffic lights would get double-drawn when exiting fullscreen and adding a
BrowserView
on macOS.