Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: setBrowserView shows the traffic light when fullscreen #30037

Closed
3 tasks done
quanweibai opened this issue Jul 7, 2021 · 2 comments
Closed
3 tasks done

[Bug]: setBrowserView shows the traffic light when fullscreen #30037

quanweibai opened this issue Jul 7, 2021 · 2 comments
Labels
13-x-y blocked/need-repro Needs a test case to reproduce the bug bug 🪲 platform/macOS

Comments

@quanweibai
Copy link

quanweibai commented Jul 7, 2021

Preflight Checklist

Electron Version

13.1.4

What operating system are you using?

macOS

Operating System Version

11.4

What arch are you using?

arm64 (including Apple Silicon)

Last Known Working Electron version

No response

Expected Behavior

when the browserWindow is fullscreen, use setBrowserView Api to switch to another page, the traffic light should not be show unless i left the fullscreen to normal window.

Actual Behavior

when use setBrowserView, the traffic light always show when window is fullscreen. the traffic light will cover on my page.

企业微信截图_ef6f844d-4887-44d7-9084-473dbac84802

Testcase Gist URL

No response

Additional Information

No response

@quanweibai quanweibai changed the title [Bug]: setBrowserView shows the traffic light [Bug]: setBrowserView shows the traffic light when fullscreen Jul 7, 2021
@sofianguy
Copy link
Contributor

Thanks for reporting this and helping to make Electron better!

Would it be possible for you to make a standalone test case with only the code necessary to reproduce the issue? For example, Electron Fiddle is a great tool for making small test cases and makes it easy to publish your test case to a gist that Electron maintainers can use.

Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.

I'm adding the blocked/need-repro label for this reason. After you make a test case, please link to it in a followup comment.

Thanks in advance! Your help is appreciated.

@sofianguy sofianguy added the blocked/need-repro Needs a test case to reproduce the bug label Jul 7, 2021
@codebytere
Copy link
Member

Fixed by #30114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13-x-y blocked/need-repro Needs a test case to reproduce the bug bug 🪲 platform/macOS
Projects
None yet
Development

No branches or pull requests

3 participants