fix: crash when clicking links with target=_blank from webview

[deepak1556]

Description of Change

Fixes #28348

When running the test case in debug build, it will be seen that RWHV::SetActive call fails because it tries to access an interface blink::FrameWidget that is not bound.

The interface usually gets bound when RenderView gets created during navigation

RenderWidgetHostImpl::BindAndGenerateCreateFrameWidgetParams
RenderViewHostImpl::CreateRenderView
WebContentsImpl::CreateRenderViewForRenderManager
RenderFrameHostManager::InitRenderView

When starting with window.opener suppressed, WebViewGuestDelegate::CreateNewGuestWindow created NSView for page which is going to be navigated immediately. Since the view was setup, it was receiving the events from the UI loop that led to the above crash.

This change removes the eager widget creation call for this case and lets chromium handle it as expected.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation is changed or added
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: fix crash when clicking links with target=_blank from webview

[nornagon]

this call to Show is new, is it needed? Is this code inspired by some analogous code in Chromium?

[deepak1556]

It is analogous to the non-guest code path from content::WebContentsImpl::CreateNewWindow, this one specifically to https://source.chromium.org/chromium/chromium/src/+/main:content/browser/web_contents/web_contents_impl.cc;l=3794-3798

[release-clerk]

Release Notes Persisted

fix crash when clicking links with target=_blank from webview

[trop]

I have automatically backported this PR to "14-x-y", please check out #29949

[trop]

I have automatically backported this PR to "12-x-y", please check out #29950

[trop]

I have automatically backported this PR to "13-x-y", please check out #29951

[linonetwo]

Click on link inside BrowserView still crush #29263 (comment)

Do you think is related?

[linonetwo]

I confirm this is fixed in v14beta, but not v13 latest