Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when clicking links with target=_blank from webview #29950

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 30, 2021

Backport of #29874

See that PR for details.

Notes: fix crash when clicking links with target=_blank from webview

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 30, 2021
@trop trop bot requested a review from deepak1556 June 30, 2021 01:10
@trop trop bot added 12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jun 30, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 30, 2021
@deepak1556
Copy link
Member

Failing tests are unrelated, merging.

@deepak1556 deepak1556 merged commit bb149b0 into 12-x-y Jun 30, 2021
@deepak1556 deepak1556 deleted the trop/12-x-y-bp-fix-crash-when-clicking-links-with-target-_blank-from-webview-1625015436046 branch June 30, 2021 16:41
@release-clerk
Copy link

release-clerk bot commented Jun 30, 2021

Release Notes Persisted

fix crash when clicking links with target=_blank from webview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant