Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly handle optional requestHeaders with onBeforeSendHeaders #29798

Merged
merged 1 commit into from Jun 22, 2021
Merged

fix: properly handle optional requestHeaders with onBeforeSendHeaders #29798

merged 1 commit into from Jun 22, 2021

Conversation

dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Jun 20, 2021 •
edited

Description of Change

Fixes #20751.

Checklist

Release Notes

Notes: Fixed an issue where request headers were cleared if the optional "requestHeaders" parameter was not included in the webRequest.onBeforeSendHeaders callback response object

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 20, 2021
@nornagon
Copy link
Member

@dsanders11 Can you improve the release notes here a bit before merging? "Fixed handling" is quite vague.

@dsanders11
Copy link
Member Author

@nornagon, updated the release note.

@zcbenz zcbenz added semver/patch backwards-compatible bug fixes target/12-x-y labels Jun 22, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 22, 2021
@zcbenz zcbenz merged commit bc8cb75 into electron:main Jun 22, 2021
@release-clerk
Copy link

release-clerk bot commented Jun 22, 2021

Release Notes Persisted

Fixed an issue where request headers were cleared if the optional "requestHeaders" parameter was not included in the webRequest.onBeforeSendHeaders callback response object

This was referenced Jun 22, 2021
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jun 22, 2021

I have automatically backported this PR to "12-x-y", please check out #29834

@trop
Copy link
Contributor

trop bot commented Jun 22, 2021

I have automatically backported this PR to "14-x-y", please check out #29835

@trop
Copy link
Contributor

trop bot commented Jun 22, 2021

I have automatically backported this PR to "13-x-y", please check out #29836

@trop trop bot removed the in-flight/13-x-y label Jun 23, 2021
BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@dsanders11 @BlackHole1
fix: properly handle optional requestHeaders with onBeforeSendHeaders (…
ac6554d 
…electron#29798)
@dsanders11 dsanders11 deleted the fix-issue-20751 branch March 14, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webRequest.onBeforeSendHeaders callback response requestHeaders not optional in 7.0.0
3 participants
@dsanders11 @nornagon @zcbenz