Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly handle optional requestHeaders with onBeforeSendHeaders #29836

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 22, 2021

Backport of #29798

See that PR for details.

Notes: Fixed an issue where request headers were cleared if the optional "requestHeaders" parameter was not included in the webRequest.onBeforeSendHeaders callback response object

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 22, 2021
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jun 22, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 22, 2021
@zcbenz zcbenz merged commit e8621de into 13-x-y Jun 23, 2021
@zcbenz zcbenz deleted the trop/13-x-y-bp-fix-properly-handle-optional-requestheaders-with-onbeforesendheaders-1624342148275 branch June 23, 2021 01:09
@release-clerk
Copy link

release-clerk bot commented Jun 23, 2021

Release Notes Persisted

Fixed an issue where request headers were cleared if the optional "requestHeaders" parameter was not included in the webRequest.onBeforeSendHeaders callback response object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants