chore: remove deprecated worldSafeExecuteJavaScript option
#28456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/cleanup-world_safe_execute_javascript
branch
2 times, most recently
from
9b6393d
to
fca3151
Compare
miniak
force-pushed
the
miniak/cleanup-world_safe_execute_javascript
branch
2 times, most recently
from
731e57b
to
5f350dd
Compare
miniak
force-pushed
the
miniak/cleanup-world_safe_execute_javascript
branch
from
5f350dd
to
b7d2a73
Compare
miniak
force-pushed
the
miniak/cleanup-world_safe_execute_javascript
branch
from
b7d2a73
to
e4154bd
Compare
nornagon
approved these changes
Apr 7, 2021
electron-cation
bot
added
api-review/approved ✅
and removed
api-review/requested 🗳
labels
jkleinsc
approved these changes
Apr 8, 2021
|
Merging as WOA failure is known flake unrelated to this PR. |
|
Release Notes Persisted
|
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Remove deprecated
worldSafeExecuteJavaScriptoption fromwebPreferences.This is already documented in Electron 14 breaking changes:
https://github.com/electron/electron/blob/master/docs/breaking-changes.md#removed-worldsafeexecutejavascript
Checklist
npm testpassesRelease Notes
Notes: Deprecated
worldSafeExecuteJavaScriptoption was removed fromwebPreferences.