refactor: clean up webFrame implementation to use gin wrappers #28497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
force-pushed
the
web-frame-clean-up
branch
from
66ec013
to
f69ac0d
Compare
mesca216
approved these changes
Apr 2, 2021
nornagon
reviewed
Apr 3, 2021
lib/renderer/web-frame-init.ts
Outdated
| // TODO(MarshallOfSound): Remove once the world-safe-execute-javascript deprecation warning is removed | ||
| if (method.startsWith('executeJavaScript')) { | ||
| return (webFrame as any)[`_${method}`](...args); | ||
| } |
There was a problem hiding this comment.
do we want to keep this in for backportability?
There was a problem hiding this comment.
Removing this (the deprecation warning) makes the implementation easier. Need to figure out how best to handle this in older branches you're right
There was a problem hiding this comment.
I am removing this in #28456
nornagon
requested changes
Apr 6, 2021
MarshallOfSound
force-pushed
the
web-frame-clean-up
branch
from
ba0064a
to
c016240
Compare
nornagon
approved these changes
Apr 7, 2021
miniak
approved these changes
Apr 8, 2021
|
@MarshallOfSound there are conflicts after my PR #28456 was merged |
The previous implementation of webFrame in the renderer process leaked sub-frame contexts and global objects across the context boundaries thus making it possible for apps to either maliciously or accidentally violate the contextIsolation boundary. This re-implementation binds all methods in native code directly to content::RenderFrame instances instead of relying on JS to provide a "window" with every method request. This is much more consistent with the rest of the Electron codebase and is substantially safer.
MarshallOfSound
force-pushed
the
web-frame-clean-up
branch
from
c016240
to
2d13f0b
Compare
|
No Release Notes |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of webFrame in the renderer process leaked sub-frame contexts and global objects across the context boundaries thus making it possible for apps to either maliciously or accidentally violate the contextIsolation boundary.
E.g.
electron.webFrame.top.contextleaked thewindowobject from the other side of the isolated world by accident (not by API, purely by implementation issues)This re-implementation binds all methods in native code directly to content::RenderFrame instances instead of relying on JS to provide a "window" with every method request. This is much more consistent with the rest of the Electron codebase and is substantially safer.
Notes: no-notes