Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: (Docs) app.setBadgeCount not supported by Windows, although it is? #34476

Closed
3 tasks done
hognevevle opened this issue Jun 8, 2022 · 4 comments
Closed
3 tasks done

Comments

@hognevevle
Copy link

hognevevle commented Jun 8, 2022

Preflight Checklist

In the docs, app.setBadgeCount is described as only being supported on Mac and Linux. It is, however, also working on Windows, and there seems to be a Windows implementation of it.

Has Windows been left out for a specific reason (i.e. we should refrain from using it for some reason), or should the docs be updated?

CleanShot 2022-06-08 at 11 15 36

@codebytere
Copy link
Member

cc @jkleinsc

@jkleinsc
Copy link
Contributor

jkleinsc commented Jun 9, 2022

@hognevevle the docs are incorrect. Badging is available on Windows and macOS. It is not available on Linux.

@jkleinsc
Copy link
Contributor

jkleinsc commented Jun 9, 2022

@hognevevle wait a minute... I stand corrected. It does work on Linux and it is undocumented on Windows because the behavior is kind of unexpected: #27067 (comment)

@erickzhao
Copy link
Member

Has Windows been left out for a specific reason (i.e. we should refrain from using it for some reason), or should the docs be updated?

I think this issue should be closed and the behaviour left undocumented as based on the comment above.

@erickzhao erickzhao closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants