Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make draggable regions work when devtools is opened on macOS #26361

Merged
merged 2 commits into from Nov 9, 2020

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Nov 6, 2020

Description of Change

Close #3647.

On macOS the draggable regions would stop working when devtools is opened, because the docked devtools is implemented by placing the devtools view under the main WebContents, and the devtools view itself is not draggable.

This PR makes the devtools view itself draggable to make the draggable regions work, and then put a view above the devtools area to exclude it from dragging.

The UI structure looks like this:

Screen Shot 2020-11-06 at 17 08 34

Checklist

Release Notes

Notes: Fix draggable regions stops working when devtools is opened on macOS

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 6, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 7, 2020
@jkleinsc jkleinsc merged commit 02a8c0a into master Nov 9, 2020
@release-clerk
Copy link

release-clerk bot commented Nov 9, 2020

Release Notes Persisted

Fix draggable regions stops working when devtools is opened on macOS

@jkleinsc jkleinsc deleted the devtools-draggable-region branch November 9, 2020 21:54
@trop
Copy link
Contributor

trop bot commented Nov 9, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Nov 9, 2020

I have automatically backported this PR to "10-x-y", please check out #26394

@trop
Copy link
Contributor

trop bot commented Nov 9, 2020

I have automatically backported this PR to "11-x-y", please check out #26395

@trop
Copy link
Contributor

trop bot commented Nov 16, 2020

@zcbenz has manually backported this PR to "9-x-y", please check out #26506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With Developer Tools open, -webkit-app-region:drag does not work
3 participants