fix: draggable regions with devtools open #29696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
fix-devtools-draggable-resize-win
branch
from
fae8ecc
to
04e9ab4
Compare
jkleinsc
approved these changes
Jun 15, 2021
MarshallOfSound
approved these changes
Jun 15, 2021
zcbenz
approved these changes
Jun 16, 2021
|
Release Notes Persisted
|
This was referenced Jun 16, 2021
|
I have automatically backported this PR to "12-x-y", please check out #29733 |
|
I have automatically backported this PR to "13-x-y", please check out #29734 |
|
I have automatically backported this PR to "14-x-y", please check out #29735 |
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #29159.
We addressed a similar problem in #26361 but draggable regions are implemented differently enough across platforms that one solution rarely addresses all of them. Windows and Linux work such that we check the current cursor position and then check to see if that falls inside draggable region bounds. On
BrowserViews, we considered that theBrowserViewbounds may not begin at (0,0) and accounted for that by offsetting the bounds when performing that calculation, but failed to take into account that this may also be the case for draggable regions inside the primaryBrowserWindow'sWebContents.When a DevTools instance is open, for example, this would mean the draggable region would be offset - this PR fixes the oversight by always ensuring that the cursor location logic is performed according to the relative bounds of theWebContentscontaining the draggable region.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where draggable regions sometimes did not work properly when DevTools is open.