Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: notifications successfully never timeout with included flag #25902

Merged
merged 3 commits into from Oct 14, 2020
Merged

fix: notifications successfully never timeout with included flag #25902

merged 3 commits into from Oct 14, 2020

Conversation

mlaurencin
Copy link
Contributor

@mlaurencin mlaurencin commented Oct 12, 2020 •
edited

Description of Change

Backport of #25820

@codebytere

Checklist

Release Notes

Notes: Fixed an issue where Windows notifications with timeoutType of 'never' did not work properly.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 12, 2020
@trop trop bot mentioned this pull request Oct 12, 2020
Merged
4 tasks
@trop trop bot added 11-x-y backport This is a backport PR labels Oct 12, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 12, 2020
codebytere
codebytere approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure is owing to an Angle/git issue & is unrelated

@mlaurencin mlaurencin requested a review from a team as a code owner October 13, 2020 21:35
@codebytere
Copy link
Member

The visibility state failures are already present on this branch as a result of the Chromium roll and unrelated.

@codebytere codebytere merged commit ed5fd9c into electron:11-x-y Oct 14, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 14, 2020

Release Notes Persisted

Fixed an issue where Windows notifications with timeoutType of 'never' did not work properly.

@trop
Copy link
Contributor

trop bot commented Oct 14, 2020

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
11-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mlaurencin @codebytere @ckerr