-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: notifications successfully never timeout with included flag #25820
fix: notifications successfully never timeout with included flag #25820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Just one comment about localization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Release Notes Persisted
|
I was unable to backport this PR to "11-x-y" cleanly; |
I was unable to backport this PR to "10-x-y" cleanly; |
I was unable to backport this PR to "9-x-y" cleanly; |
@mlaurencin has manually backported this PR to "9-x-y", please check out #25862 |
@mlaurencin has manually backported this PR to "11-x-y", please check out #25902 |
@mlaurencin has manually backported this PR to "10-x-y", please check out #25926 |
Description of Change
Closes #22192
This PR is fixing the bug that was appearing in using the timeoutType='never' option when creating a Windows toast notification. Before the notification was still disappearing after about 7 seconds of being on the screen. This fix adds a "Close" button to the notification, which causes the scenario='reminder' attribute of the notification XML to be respected and the notification to never timeout. This attribute is only respected when a button is present on the notification XML.
Before:
After:
cc @codebytere
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where Windows notifications with
timeoutType
of 'never' did not work properly.