Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notifications successfully never timeout with included flag #25820

Merged
merged 11 commits into from
Oct 9, 2020

Conversation

mlaurencin
Copy link
Contributor

@mlaurencin mlaurencin commented Oct 8, 2020

Description of Change

Closes #22192

This PR is fixing the bug that was appearing in using the timeoutType='never' option when creating a Windows toast notification. Before the notification was still disappearing after about 7 seconds of being on the screen. This fix adds a "Close" button to the notification, which causes the scenario='reminder' attribute of the notification XML to be respected and the notification to never timeout. This attribute is only respected when a button is present on the notification XML.

Before:

image (1)

After:

image

cc @codebytere

Checklist

Release Notes

Notes: Fixed an issue where Windows notifications with timeoutType of 'never' did not work properly.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 8, 2020
@codebytere codebytere self-requested a review October 8, 2020 02:53
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just one comment about localization.

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

electron_strings.grdp Outdated Show resolved Hide resolved
electron_strings.grdp Outdated Show resolved Hide resolved
@codebytere codebytere requested a review from ckerr October 9, 2020 00:29
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 9, 2020
@codebytere codebytere merged commit 0195319 into electron:master Oct 9, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 9, 2020

Release Notes Persisted

Fixed an issue where Windows notifications with timeoutType of 'never' did not work properly.

@trop
Copy link
Contributor

trop bot commented Oct 9, 2020

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/11-x-y label Oct 9, 2020
@trop
Copy link
Contributor

trop bot commented Oct 9, 2020

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/10-x-y label Oct 9, 2020
@trop
Copy link
Contributor

trop bot commented Oct 9, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Oct 9, 2020

@mlaurencin has manually backported this PR to "9-x-y", please check out #25862

@trop
Copy link
Contributor

trop bot commented Oct 12, 2020

@mlaurencin has manually backported this PR to "11-x-y", please check out #25902

@trop
Copy link
Contributor

trop bot commented Oct 13, 2020

@mlaurencin has manually backported this PR to "10-x-y", please check out #25926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification timeoutType='never' doesn't work
3 participants