New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: honor pageRanges when printing #25600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are typescript errors:
ERROR in /Users/distiller/project/src/electron/lib/browser/api/web-contents.ts
[tsl] ERROR in /Users/distiller/project/src/electron/lib/browser/api/web-contents.ts(280,27)
TS2339: Property 'from' does not exist on type 'PageRanges[]'.
ERROR in /Users/distiller/project/src/electron/lib/browser/api/web-contents.ts
[tsl] ERROR in /Users/distiller/project/src/electron/lib/browser/api/web-contents.ts(285,27)
TS2339: Property 'to' does not exist on type 'PageRanges[]'.
ERROR in /Users/distiller/project/src/electron/lib/browser/api/web-contents.ts
[tsl] ERROR in /Users/distiller/project/src/electron/lib/browser/api/web-contents.ts(292,24)
TS2339: Property 'from' does not exist on type 'PageRanges[]'.
ERROR in /Users/distiller/project/src/electron/lib/browser/api/web-contents.ts
[tsl] ERROR in /Users/distiller/project/src/electron/lib/browser/api/web-contents.ts(293,22)
TS2339: Property 'to' does not exist on type 'PageRanges[]'.
@codebytere is this PR still live? |
@ckerr i need to figure out the TS stuff but yes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a doc change was missed - other than that LGTM
ad87d5d
to
9d1a3dd
Compare
9d1a3dd
to
804cbe8
Compare
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
804cbe8
to
fc9c681
Compare
Release Notes Persisted
|
Backport of #25064.
See that PR for more details.
Notes: Fixed an issue where pageRanges was not properly honored when printing.