fix: honor pageRanges when printing #25064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
pageranges-printing
branch
from
1eb4c8e
to
6d008c7
Compare
codebytere
changed the title
codebytere
changed the title
codebytere
force-pushed
the
pageranges-printing
branch
9 times, most recently
from
ccf6f05
to
f40eac9
Compare
zcbenz
requested changes
Aug 25, 2020
codebytere
force-pushed
the
pageranges-printing
branch
from
53974f1
to
a436c2c
Compare
zcbenz
approved these changes
Aug 26, 2020
ckerr
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
I've tested this PR on Windows 10 with the sample code at https://gist.github.com/0c1c8affb9262ae83bde4d08d3401f0c and the ranges are working as expected 👍
Note about the screenshot: the Windows screenshot reads "1-3" rather than "1-4" as in e.g. the Linux screenshot, but there are indeed only 3 pages on Windows and so the pageRange is correct.
MarshallOfSound
approved these changes
Aug 27, 2020
|
Release Notes Persisted
|
|
@codebytere has manually backported this PR to "10-x-y", please check out #25597 |
|
@codebytere has manually backported this PR to "11-x-y", please check out #25600 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #25013.
The print ranges in Chromium's print job settings were not being properly
plumbed through to various platforms' UI through the correct codepaths.
This fixes that by setting them should they exist.
Upstream CL open at https://chromium-review.googlesource.com/c/chromium/src/+/2380886
On macOS
On Linux
On Windows
Tested with https://gist.github.com/0c1c8affb9262ae83bde4d08d3401f0c.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where pageRanges was not properly honored when printing.