Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent destroyed view references from causing crashes #25509

Merged
merged 13 commits into from Sep 21, 2020
Merged

fix: prevent destroyed view references from causing crashes #25509

merged 13 commits into from Sep 21, 2020

Commits on Sep 17, 2020

  1. fix: prevent destroyed view references from causing crashes

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    6de5ddf View commit details
    Browse the repository at this point in the history

  2. Remove extraneous comments

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    20b6983 View commit details
    Browse the repository at this point in the history

  3. Relocate crash test to proper location

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    4b498f8 View commit details
    Browse the repository at this point in the history

  4. Add WebContentsObserver

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    22811e4 View commit details
    Browse the repository at this point in the history

  5. Add nullptr check and inspectable observer

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    4f7917b View commit details
    Browse the repository at this point in the history

  6. Remote initial test file

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    547ab09 View commit details
    Browse the repository at this point in the history

  7. Add test cases to test file

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    5d87d6b View commit details
    Browse the repository at this point in the history

  8. Rename and move testing file

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    1c8581c View commit details
    Browse the repository at this point in the history

  9. Fix linting errors

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    4cdabc7 View commit details
    Browse the repository at this point in the history

  10. Make functions exit early on check

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    5018485 View commit details
    Browse the repository at this point in the history

  11. Fix setBackgroundColor function call in test file

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    e7e68fc View commit details
    Browse the repository at this point in the history

  12. Fix styling of test file

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    505bb8a View commit details
    Browse the repository at this point in the history

  13. Fix mac name mismatch and make variable name more clear

    @mlaurencin @electron-bot
    mlaurencin authored and electron-bot committed Sep 17, 2020
    Copy the full SHA
    c83ea2f View commit details
    Browse the repository at this point in the history