Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent destroyed view references from causing crashes #25509

Merged
merged 13 commits into from Sep 21, 2020
Merged

fix: prevent destroyed view references from causing crashes #25509

merged 13 commits into from Sep 21, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 17, 2020

Backport of #25411

See that PR for details.

Notes: Fixed crashes caused by attempting to modify destroyed views

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 17, 2020
@trop trop bot mentioned this pull request Sep 17, 2020
Merged
6 tasks
@trop trop bot added 11-x-y backport This is a backport PR labels Sep 17, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 17, 2020
@zcbenz zcbenz merged commit 0f4f5ac into 11-x-y Sep 21, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 21, 2020

Release Notes Persisted

Fixed crashes caused by attempting to modify destroyed views

@zcbenz zcbenz deleted the trop/11-x-y-bp-fix-prevent-destroyed-view-references-from-causing-crashes-1600301470074 branch September 21, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
11-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zcbenz @codebytere @mlaurencin