[wip] feat(extensions): add enable/disable extension methods to Session

[samuelmaddock]

Description of Change

Allows the user to toggle an extension at runtime.

This is useful in cases where an extension should be loaded, but the user can decide whether or not it should run (ie. Chrome's extension toggle preferences).

TODO:

• Figure out whether to add Session.isExtensionEnabled(boolean) or modify Session.getAllExtensions() to include enabled state.
• Check if this can help solve Ability to disable pdf viewer #24977 (I did notice that the PDF extension shows up in an extension-ready event added in feat(extensions): expose ExtensionRegistryObserver events in Session #25385). PDF extension gets disabled, but it simply fails to load the plugin (screenshot).
• Verify that the modified ExtensionPrefs values are only in-memory.

Ref #19447

cc @sentialx - Let me know if you have any input on the direction here for these APIs.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation is changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Added Session.enableExtension(extensionId) and Session.disableExtension(extensionId).

[sentialx]

@samuelmaddock I think it would be convenient to include enabled property into the Extension object instead of making a separate method for that. Also, would be nice to have extension-enabled and extension-disabled events, unless extension-loaded and extension-unloaded do the same thing.

Other than that, I think we should consider making an extensions namespace to avoid extension word in every event and method.
i.e. session.extensions.load(path)
What are your thoughts on this?

[samuelmaddock]

@samuelmaddock I think it would be convenient to include enabled property into the Extension object instead of making a separate method for that. Also, would be nice to have extension-enabled and extension-disabled events, unless extension-loaded and extension-unloaded do the same thing.

I thought about adding Extension.enabled initially, but it would make directly converting from an extensions::Extension more complex. Additionally, it would need to be a fixed value which is set when serialized. That could cause confusion for folks thinking it would reflect its real-time value.

I'm not totally against the idea, I'm just not sure how best to implement it.

Other than that, I think we should consider making an extensions namespace to avoid extension word in every event and method.
i.e. session.extensions.load(path)
What are your thoughts on this?

I think that would be a clean approach. I created an issue to track this idea: #25418

[samuelmaddock]

Closing this for now. I'll re-open in the future if this becomes relevant again.