feat(extensions): expose ExtensionRegistryObserver events in Session #25385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extensions can be loaded and unloaded for various reasons. In some cases this can occur by no means of the Electron programmer, such as in the case of chrome.runtime.reload(). In order to be able to manage state about extensions outside of Electron's APIs, events reloaded to loading and unloaded are needed.
9 tasks
|
Pinging @electron/wg-api since I think this will require their review. |
nornagon
requested changes
Sep 10, 2020
4 tasks
nornagon
approved these changes
Sep 11, 2020
|
The API WG approved this at the Sept 21, 2020 meeting. |
jkleinsc
approved these changes
Sep 23, 2020
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Extensions can be loaded or unloaded for various reasons. In some cases, this can occur by no means of the Electron programmer, such as in the case of
chrome.runtime.reload().In order to be able to manage state about extensions outside of Electron's APIs, events related to loading and unloaded extensions are needed. The only alternative would be to monkey-patch the
Sessionprototype.The use case I have is to manage state in my own implementation of
chrome.browserAction. I need to know when an extension is added or removed to set or delete saved state.Ref #19447
cc @nornagon @sentialx
Checklist
npm testpassesRelease Notes
Notes: Add
extension-loaded,extension-unloaded, andextension-readyevents toSession.