Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only focus a webContents if the window was not initially hidden #25292

Merged
merged 1 commit into from Sep 4, 2020
Merged

fix: only focus a webContents if the window was not initially hidden #25292

merged 1 commit into from Sep 4, 2020

Conversation

MarshallOfSound
Copy link
Member

Fixes #25287

Notes: Fixed an issue where document.hasFocus and document.activeElement would be inconsistent upon showing a window that was initially created with show: false

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 2, 2020
zcbenz
zcbenz approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested a few cases and I confirm it does not have side effects.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 3, 2020
@zcbenz zcbenz merged commit a6b9f9d into master Sep 4, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 4, 2020

Release Notes Persisted

Fixed an issue where document.hasFocus and document.activeElement would be inconsistent upon showing a window that was initially created with show: false

@zcbenz zcbenz deleted the fix-focus-on-hidden-window branch September 4, 2020 06:57
@trop
Copy link
Contributor

trop bot commented Sep 4, 2020

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Sep 4, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Sep 4, 2020

I have automatically backported this PR to "11-x-y", please check out #25323

@MarshallOfSound MarshallOfSound mentioned this pull request Sep 4, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Sep 4, 2020

@MarshallOfSound has manually backported this PR to "10-x-y", please check out #25330

@deepak1556 deepak1556 mentioned this pull request Apr 28, 2021
Closed
3 tasks
@rzhao271 rzhao271 mentioned this pull request May 12, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing focus event on app activation, for window created with show: false
3 participants
@MarshallOfSound @zcbenz @codebytere