Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only focus a webContents if the window was not initially hidden #25330

Merged
merged 1 commit into from Sep 8, 2020
Merged

fix: only focus a webContents if the window was not initially hidden #25330

merged 1 commit into from Sep 8, 2020

Conversation

MarshallOfSound
Copy link
Member

Backport of #25292

See that PR for details.

Notes: Fixed an issue where document.hasFocus and document.activeElement would be inconsistent upon showing a window that was initially created with show: false

@trop @MarshallOfSound
fix: only focus a webContents if the window was not initially hidden (#…
1dad46f 
…25323)

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 4, 2020
@trop trop bot mentioned this pull request Sep 4, 2020
Merged
@trop trop bot added 10-x-y backport This is a backport PR labels Sep 4, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 4, 2020
@zcbenz zcbenz merged commit fa3652a into 10-x-y Sep 8, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 8, 2020

Release Notes Persisted

Fixed an issue where document.hasFocus and document.activeElement would be inconsistent upon showing a window that was initially created with show: false

@zcbenz zcbenz deleted the fix-focus-on-hidden-window-10 branch September 8, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarshallOfSound @zcbenz