Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple dock icons when calling dock.show/hide #25269

Merged
merged 2 commits into from Sep 3, 2020

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Sep 2, 2020

Description of Change

Close #24407.

Work around a bug of macOS that, when calling dock.show/hide in very short interval, multiple dock icons would be left in the system.

I don't have a test for this, since it is a visual bug of Finder and the APIs are just lying.

Checklist

Release Notes

Notes: Fix multiple dock icons being left in system when calling dock.show/hide on macOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 2, 2020
codebytere
codebytere previously approved these changes Sep 2, 2020
@codebytere codebytere dismissed their stale review September 2, 2020 17:59

meant to request changes

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zcbenz

app module dock APIs dock.hide should not throw

looks like a legitimate failure of this PR

@zcbenz
Copy link
Member Author

zcbenz commented Sep 3, 2020

@codebytere I have adjusted the order of the tests to make it pass, it is not really decent but I can't find a better way.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 3, 2020
@zcbenz zcbenz merged commit 43485b8 into master Sep 3, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 3, 2020

Release Notes Persisted

Fix multiple dock icons being left in system when calling dock.show/hide on macOS.

@zcbenz zcbenz deleted the dock-show-hide-chain branch September 3, 2020 11:46
@trop
Copy link
Contributor

trop bot commented Sep 3, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Sep 3, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/9-x-y label Sep 3, 2020
@trop
Copy link
Contributor

trop bot commented Sep 3, 2020

I have automatically backported this PR to "10-x-y", please check out #25299

@trop
Copy link
Contributor

trop bot commented Sep 3, 2020

I have automatically backported this PR to "11-x-y", please check out #25300

@trop trop bot removed the target/11-x-y label Sep 3, 2020
@trop
Copy link
Contributor

trop bot commented Sep 3, 2020

@zcbenz has manually backported this PR to "9-x-y", please check out #25301

@trop
Copy link
Contributor

trop bot commented Sep 3, 2020

@zcbenz has manually backported this PR to "8-x-y", please check out #25302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple app dock icons shown
2 participants