Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple dock icons when calling dock.show/hide #25301

Merged
merged 1 commit into from Sep 3, 2020
Merged

fix: multiple dock icons when calling dock.show/hide #25301

merged 1 commit into from Sep 3, 2020

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Sep 3, 2020

Backport of #25269

See that PR for details.

Notes: Fix multiple dock icons being left in system when calling dock.show/hide on macOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 3, 2020
@trop trop bot mentioned this pull request Sep 3, 2020
Merged
4 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Sep 3, 2020
@zcbenz
Copy link
Member Author

zcbenz commented Sep 3, 2020

Note that some changes in api-app-spec.ts are added by linter automatically.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 3, 2020
@codebytere codebytere merged commit 35b348a into 9-x-y Sep 3, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 3, 2020

Release Notes Persisted

Fix multiple dock icons being left in system when calling dock.show/hide on macOS.

@codebytere codebytere deleted the dock-show-hide-chain-9 branch September 3, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @codebytere