Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register for connected standby changes #25076

Merged
merged 1 commit into from Aug 24, 2020
Merged

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Aug 21, 2020

Description of Change

Close #24499.

For Windows 8 and later, a new "connected standby" mode has been added and we must explicitly register for its notifications to get the suspend/resume events.

Checklist

Release Notes

Notes: Fix powerMonitor not emitting suspend/resume events on some Windows machines.

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Aug 21, 2020
@codebytere codebytere merged commit 5ed3460 into master Aug 24, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 24, 2020

Release Notes Persisted

Fix powerMonitor not emitting suspend/resume events on some Windows machines.

@codebytere codebytere deleted the connected-standby branch August 24, 2020 20:09
@trop
Copy link
Contributor

trop bot commented Aug 24, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/8-x-y label Aug 24, 2020
@trop
Copy link
Contributor

trop bot commented Aug 24, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Aug 24, 2020

I have automatically backported this PR to "10-x-y", please check out #25111

@miniak
Copy link
Contributor

miniak commented Aug 27, 2020

@zcbenz / @codebytere RegisterSuspendResumeNotification is only available since Windows 8. It needs to be resolved dynamically with GetProcAddress

@miniak
Copy link
Contributor

miniak commented Aug 27, 2020

/trop run backport-to 11-x-y

@trop
Copy link
Contributor

trop bot commented Aug 27, 2020

The backport process for this PR has been manually initiated -
sending your commits to "11-x-y"!

@trop
Copy link
Contributor

trop bot commented Aug 27, 2020

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/11-x-y label Aug 27, 2020
@trop
Copy link
Contributor

trop bot commented Aug 27, 2020

@miniak has manually backported this PR to "8-x-y", please check out #25163

@trop
Copy link
Contributor

trop bot commented Aug 27, 2020

@miniak has manually backported this PR to "9-x-y", please check out #25165

@trop trop bot removed the in-flight/9-x-y label Aug 28, 2020
zcbenz added a commit that referenced this pull request Aug 28, 2020
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
@trop trop bot added the merged/9-x-y label Aug 28, 2020
zcbenz added a commit that referenced this pull request Aug 28, 2020
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

powerMonitor does not fire 'suspend" event, Re:open 24244
3 participants