Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve RegisterSuspendResumeNotification dynamically #25162

Merged
merged 1 commit into from Aug 27, 2020
Merged

fix: resolve RegisterSuspendResumeNotification dynamically #25162

merged 1 commit into from Aug 27, 2020

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Aug 27, 2020 •
edited by deepak1556

Description of Change

Fix Electron not working on Windows 7 after #25076
Screen Shot 2020-08-27 at 4 49 39 PM

Checklist

Release Notes

Notes: Fixed Electron not working on Windows 7 after #25076

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 27, 2020
@miniak miniak self-assigned this Aug 27, 2020
@miniak miniak mentioned this pull request Aug 27, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Aug 27, 2020

@miniak has manually backported this PR to "8-x-y", please check out #25163

@miniak miniak mentioned this pull request Aug 27, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Aug 27, 2020

@miniak has manually backported this PR to "9-x-y", please check out #25165

@miniak miniak added the fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases label Aug 27, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 27, 2020
@codebytere codebytere merged commit 97755bb into master Aug 27, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 27, 2020

Release Notes Persisted

Fixed Electron not working on Windows 7 after #25076

@codebytere codebytere deleted the miniak/fix-connected-standby branch August 27, 2020 18:20
This was referenced Aug 27, 2020
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 27, 2020

I have automatically backported this PR to "10-x-y", please check out #25167

@trop
Copy link
Contributor

trop bot commented Aug 27, 2020

I have automatically backported this PR to "11-x-y", please check out #25168

@zcbenz
Copy link
Member

zcbenz commented Aug 28, 2020

Thanks for fixing this! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees

@miniak miniak

Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @zcbenz @deepak1556 @codebytere