New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: save normal window bounds when maximizing #25051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Release Notes Persisted
|
I was unable to backport this PR to "10-x-y" cleanly; |
I was unable to backport this PR to "8-x-y" cleanly; |
I was unable to backport this PR to "9-x-y" cleanly; |
* fix: save normal window bounds when maximizing * fix: prevent maximize being emitted twice
@codebytere has manually backported this PR to "10-x-y", please check out #25132 |
@codebytere has manually backported this PR to "9-x-y", please check out #25133 |
Description of Change
Close #22440.
Close #24780.
The normal bounds of window should be saved when maximizing, otherwise the window size would be slightly changed after unmaximizing. We are already doing the same thing when minimizing.
This PR also includes a fix to prevent maximize/minimize events to be emitted multiples due to our SetWindowPlacement hack.
Checklist
npm test
passesRelease Notes
Notes: Fix window size being changed after unmaximizing.