Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save normal window bounds when maximizing #25051

Merged
merged 2 commits into from Aug 24, 2020

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Aug 19, 2020

Description of Change

Close #22440.
Close #24780.

The normal bounds of window should be saved when maximizing, otherwise the window size would be slightly changed after unmaximizing. We are already doing the same thing when minimizing.

This PR also includes a fix to prevent maximize/minimize events to be emitted multiples due to our SetWindowPlacement hack.

Checklist

Release Notes

Notes: Fix window size being changed after unmaximizing.

@zcbenz zcbenz requested a review from deepak1556 August 19, 2020 23:37
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 19, 2020
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 20, 2020
@codebytere codebytere merged commit cd3fadc into master Aug 24, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 24, 2020

Release Notes Persisted

Fix window size being changed after unmaximizing.

@codebytere codebytere deleted the frameless-maximize-twice branch August 24, 2020 20:32
@trop
Copy link
Contributor

trop bot commented Aug 24, 2020

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Aug 24, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Aug 24, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

codebytere pushed a commit that referenced this pull request Aug 25, 2020
* fix: save normal window bounds when maximizing

* fix: prevent maximize being emitted twice
@trop
Copy link
Contributor

trop bot commented Aug 25, 2020

@codebytere has manually backported this PR to "10-x-y", please check out #25132

@trop
Copy link
Contributor

trop bot commented Aug 25, 2020

@codebytere has manually backported this PR to "9-x-y", please check out #25133

@trop
Copy link
Contributor

trop bot commented Aug 26, 2020

@zcbenz has manually backported this PR to "8-x-y", please check out #25148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants