Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calculate frame when setting window placement #25014

Merged
merged 1 commit into from Aug 19, 2020

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Aug 18, 2020

Description of Change

Close #22393.

When calling SetWindowPlacement, we should let Chromium handle the WM_NCCALCSIZE message otherwise the window size would be wrong for frameless window.

Checklist

Release Notes

Notes: Fix frameless window's size being changed when restored from minimized state.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 18, 2020
@deepak1556
Copy link
Member

This doesn't seem to fix #22440 , I thought it would be same codepath for both.

@zcbenz
Copy link
Member Author

zcbenz commented Aug 19, 2020

This doesn't seem to fix #22440 , I thought it would be same codepath for both.

I confirm this PR does not fix it, I'll take a look at it too.

Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 19, 2020
@codebytere
Copy link
Member

https://ci.appveyor.com/project/electron-bot/electron-ia32-testing/builds/34730405 is green, idk why it's still showing as pending.

@codebytere codebytere merged commit 52d7afa into master Aug 19, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 19, 2020

Release Notes Persisted

Fix frameless window's size being changed when restored from minimized state.

@codebytere codebytere deleted the frameless-placement branch August 19, 2020 19:34
@trop
Copy link
Contributor

trop bot commented Aug 19, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Aug 19, 2020

I have automatically backported this PR to "10-x-y", please check out #25044

@trop trop bot removed the target/10-x-y label Aug 19, 2020
@trop
Copy link
Contributor

trop bot commented Aug 19, 2020

I have automatically backported this PR to "9-x-y", please check out #25045

@trop
Copy link
Contributor

trop bot commented Aug 20, 2020

@zcbenz has manually backported this PR to "8-x-y", please check out #25057

@pejman1
Copy link

pejman1 commented Aug 25, 2020

Restoring windows from minimized state has been fixed But the bug is still there while restore from maximize state

I am using Electron version 10.0.0

@deepak1556
Copy link
Member

@pejman1 it is fixed by #25051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frameless minimum sized window is not restored to previous size after minimize and restore
4 participants