Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use non-symbols in isURLInstance check #24862

Merged
merged 5 commits into from Aug 17, 2020
Merged

fix: use non-symbols in isURLInstance check #24862

merged 5 commits into from Aug 17, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 5, 2020

Backport of #24831

See that PR for details.

Notes: Fixed an issue where some Node.js methods would not work with URL instances constructed in the renderer process.

@trop trop bot requested a review from a team as a code owner August 5, 2020 22:06
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 5, 2020
@trop trop bot requested a review from codebytere August 5, 2020 22:06
@trop trop bot mentioned this pull request Aug 5, 2020
Merged
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Aug 5, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 5, 2020
@codebytere codebytere force-pushed the trop/9-x-y-bp-fix-use-non-symbols-in-isurlinstance-check-1596665166784 branch from 7863e81 to 2930fb3 Compare August 6, 2020 16:02
@codebytere codebytere force-pushed the trop/9-x-y-bp-fix-use-non-symbols-in-isurlinstance-check-1596665166784 branch from 2930fb3 to 9c91c07 Compare August 6, 2020 17:07
zcbenz
zcbenz previously requested changes Aug 17, 2020
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch needs to be updated.

@codebytere codebytere dismissed zcbenz’s stale review August 17, 2020 15:35

Dismissing as patches have been successfully updated

@codebytere codebytere merged commit 79f6ba4 into 9-x-y Aug 17, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 17, 2020

Release Notes Persisted

Fixed an issue where some Node.js methods would not work with URL instances constructed in the renderer process.

@codebytere codebytere deleted the trop/9-x-y-bp-fix-use-non-symbols-in-isurlinstance-check-1596665166784 branch August 17, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@zcbenz zcbenz zcbenz left review comments

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @codebytere