Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash when navigating from a page with webview that has inherited zoom level #24757

Merged
merged 4 commits into from Jul 28, 2020
Merged

fix: crash when navigating from a page with webview that has inherited zoom level #24757

merged 4 commits into from Jul 28, 2020

Commits on Jul 28, 2020

  1. fix: cleanup webview zoom level observers on navigation

    @deepak1556
    deepak1556 committed Jul 28, 2020
    Copy the full SHA
    bc7b5c4 View commit details
    Browse the repository at this point in the history

  2. add spec

    @deepak1556
    deepak1556 committed Jul 28, 2020
    Copy the full SHA
    6a51a04 View commit details
    Browse the repository at this point in the history

  3. webview should be on same partition

    @deepak1556
    deepak1556 committed Jul 28, 2020
    Copy the full SHA
    c6f7799 View commit details
    Browse the repository at this point in the history

  4. wait for webview to finish loading

    @deepak1556
    deepak1556 committed Jul 28, 2020
    Copy the full SHA
    97812a8 View commit details
    Browse the repository at this point in the history