Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash when navigating from a page with webview that has inherited zoom level #24757

Merged
merged 4 commits into from Jul 28, 2020
Merged

fix: crash when navigating from a page with webview that has inherited zoom level #24757

merged 4 commits into from Jul 28, 2020

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Jul 28, 2020 •
edited

Description of Change

Repro https://gist.github.com/deepak1556/4e98046880c9ff4fecc03813708a2264

Refs microsoft/vscode#102195

Checklist

Release Notes

Notes: fix crash when navigating from a page with webview that has inherited zoom level

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 28, 2020
@deepak1556 deepak1556 requested a review from zcbenz July 28, 2020 06:06
@deepak1556 deepak1556 mentioned this pull request Jul 28, 2020
Closed
@deepak1556
Copy link
Member Author

Failing tests are unrelated, merging.

@deepak1556 deepak1556 merged commit b6321cc into master Jul 28, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 28, 2020

Release Notes Persisted

fix crash when navigating from a page with webview that has inherited zoom level

@deepak1556 deepak1556 deleted the robo/webview_zoom_crash branch July 28, 2020 20:00
@trop
Copy link
Contributor

trop bot commented Jul 28, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

This was referenced Jul 28, 2020
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 28, 2020

I have automatically backported this PR to "10-x-y", please check out #24763

@trop
Copy link
Contributor

trop bot commented Jul 28, 2020

I have automatically backported this PR to "9-x-y", please check out #24764

deepak1556 added a commit that referenced this pull request Jul 28, 2020
@deepak1556
fix: crash when navigating from a page with webview that has inherite…
80c9024 
…d zoom level (#24757)
@deepak1556 deepak1556 mentioned this pull request Jul 28, 2020
Merged
7 tasks
@trop
Copy link
Contributor

trop bot commented Jul 28, 2020

@deepak1556 has manually backported this PR to "8-x-y", please check out #24766

jkleinsc pushed a commit that referenced this pull request Aug 3, 2020
@deepak1556
fix: crash when navigating from a page with webview that has inherite…
d3e5b79 
…d zoom level (#24757) (#24766)
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deepak1556 @nornagon @MarshallOfSound