Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use node_bindings loop for clarity #24391

Merged
merged 1 commit into from Jul 3, 2020
Merged

chore: use node_bindings loop for clarity #24391

merged 1 commit into from Jul 3, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jul 1, 2020 •
edited

Description of Change

Clarify loop being used by always passing in node_bindings_->uv_loop(), as it will be uv_default_loop unless we're in a WebWorkerObserver. This change is for consistency and should affect no behavior.

cc @ckerr @zcbenz

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 1, 2020
@codebytere codebytere requested review from ckerr and zcbenz July 1, 2020 20:28
deepak1556
deepak1556 approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the backport necessary ?

@codebytere
Copy link
Member Author

@deepak1556 backporting change like this reduces code drift and makes it easier for trop to succeed, so i normally try where possible :)

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 2, 2020
@codebytere codebytere merged commit 4398ecb into master Jul 3, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 3, 2020

No Release Notes

@codebytere codebytere deleted the use-binding-loop branch July 3, 2020 16:19
This was referenced Jul 3, 2020
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 3, 2020

I have automatically backported this PR to "10-x-y", please check out #24416

@trop
Copy link
Contributor

trop bot commented Jul 3, 2020

I have automatically backported this PR to "8-x-y", please check out #24417

@trop trop bot removed target/10-x-y labels Jul 3, 2020
@trop
Copy link
Contributor

trop bot commented Jul 3, 2020

I have automatically backported this PR to "9-x-y", please check out #24418

@sang612345
Copy link

Tôi không nhận được được thông báo mật khẩu và số sim của tôi cũng bị khóa

@trop trop bot removed the in-flight/9-x-y label Jul 4, 2020
sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
@codebytere @sentialx
chore: use node_bindings loop for clarity (electron#24391)
6f824d6
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
@codebytere @sentialx
chore: use node_bindings loop for clarity (electron#24391)
85c994d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@codebytere @sang612345 @ckerr @nornagon @zcbenz @deepak1556