Skip to content

Commit

Permalink
chore: use node_bindings loop for clarity (#24391)
Browse files Browse the repository at this point in the history
  • Loading branch information
codebytere committed Jul 3, 2020
1 parent 9106d0c commit 4398ecb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion shell/browser/electron_browser_main_parts.cc
Expand Up @@ -251,7 +251,7 @@ ElectronBrowserMainParts::ElectronBrowserMainParts(
browser_(new Browser),
node_bindings_(
NodeBindings::Create(NodeBindings::BrowserEnvironment::BROWSER)),
electron_bindings_(new ElectronBindings(uv_default_loop())) {
electron_bindings_(new ElectronBindings(node_bindings_->uv_loop())) {
DCHECK(!self_) << "Cannot have two ElectronBrowserMainParts";
self_ = this;
}
Expand Down
2 changes: 1 addition & 1 deletion shell/renderer/electron_renderer_client.cc
Expand Up @@ -37,7 +37,7 @@ bool IsDevToolsExtension(content::RenderFrame* render_frame) {
ElectronRendererClient::ElectronRendererClient()
: node_bindings_(
NodeBindings::Create(NodeBindings::BrowserEnvironment::RENDERER)),
electron_bindings_(new ElectronBindings(uv_default_loop())) {}
electron_bindings_(new ElectronBindings(node_bindings_->uv_loop())) {}

ElectronRendererClient::~ElectronRendererClient() {
asar::ClearArchives();
Expand Down

0 comments on commit 4398ecb

Please sign in to comment.