fix: remove same-tag notifications before showing new ones

[codebytere]

Description of Change

Closes #24290.

Fixes an issue where notifications where not being closed properly when more than one notification was created in the renderer process with the same tag.

Per spec: https://notifications.spec.whatwg.org/#showing-a-notification

Tested with https://gist.github.com/fd16a663434667d2096cd31ec7f2662f.

cc @MarshallOfSound @zcbenz

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
• This is NOT A BREAKING CHANGE. Breaking changes may not be merged to master until 11-x-y is branched.

Release Notes

Notes: Fixed an issue where some old notifications were not properly removed from the Notification Center on macOS.

[MarshallOfSound]

This isn't expected behavior, we don't want to dismiss the previous notification before showing a new one.

The line you reference here -->

electron/shell/browser/api/electron_api_notification.cc

Line 216 in 765c08c

Close();

is intended to close this notification before showing it again as you can re-use Notification instances in the main process.

In other words, this:

This ensures that, like we do in the main API

Is wrong

And we don't want to do this:

we explicitly close the most recent notification from the Notification Center on macOS before creating and displaying a new one.

as it isn't in any way expected, we want to have the ability to stack multiple notifications in the notification center.

[release-clerk]

Release Notes Persisted

Fixed an issue where some old notifications were not properly removed from the Notification Center on macOS.

[trop]

I have automatically backported this PR to "10-x-y", please check out #24404

[trop]

I have automatically backported this PR to "8-x-y", please check out #24405

[trop]

I have automatically backported this PR to "9-x-y", please check out #24406

[r0stig]

I think this PR introduced an old bug, explained in this issue: #17706

Quick tldr: when showing a new notification with the same tag as the one before both the newly created notification and the one before gets it's onclose callback called and the user can't click on the notification (the onclick handler won't fire).