Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismissed notifications with same tag won't trigger onclick handler for next notification #25665

Closed
3 tasks done
r0stig opened this issue Sep 28, 2020 · 2 comments
Closed
3 tasks done

Comments

@r0stig
Copy link
Contributor

r0stig commented Sep 28, 2020

Preflight Checklist

Issue Details

Expected Behavior

The onclick-handler for a notification in the renderer process should always be fired upon click when the notification object shares the same tag.

Actual Behavior

Only every second notification click fires the onclick handler when the notifications share the same tag when the notification before is dismissed manually or automatically.

To Reproduce

https://github.com/r0stig/electron-quick-start

$ git clone git@github.com:r0stig/electron-quick-start.git
$ npm install
$ npm start
  • Click on the button "send notification"
  • Wait for the notification to be closed automatically or dismiss manually
  • Click on the button "send notification"
  • Click on the notification and notice that the onclick-handler did not fire

Screenshots

See clip:
onclick_fails

Additional Information

This bug is similar to this closed issue a while ago: #17706

@r0stig r0stig changed the title Dismissed notifications with same tag wont trigger onclick handler Dismissed notifications with same tag wont trigger onclick handler for next notification Sep 28, 2020
@r0stig r0stig changed the title Dismissed notifications with same tag wont trigger onclick handler for next notification Dismissed notifications with same tag won't trigger onclick handler for next notification Sep 28, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Oct 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants