fix: handle non-client area pointer events from pen on Win10 #24042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
force-pushed
the
fix-pen-on-window
branch
from
4eb7568
to
0f4b547
Compare
deepak1556
approved these changes
Jun 10, 2020
|
Release Notes Persisted
|
This was referenced Jun 12, 2020
|
I have automatically backported this PR to "8-x-y", please check out #24101 |
|
I have automatically backported this PR to "10-x-y", please check out #24102 |
|
I have automatically backported this PR to "9-x-y", please check out #24103 |
|
I have automatically backported this PR to "7-3-x", please check out #24104 |
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Jul 30, 2020
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix #21440.
Chromium does not handle non-client area pointer events from pen on Windows 10, which ends up with native window frame not responding to pen touches. This is not a problem in Chromium because they use custom frame instead of native frame.
This PR routes the non-client area pointer events from pen to touch events handlers, so they can be properly handled. This should not have side effects since we don't need to distinguish pen from finger in the non-client window frame.
This is tested on Surface Pro 7 with a pen.
Checklist
npm testpassesRelease Notes
Notes: Fix window titlebar not responding to pen on Windows 10