Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing isComposing KeyboardEvent property #24015

Merged
merged 2 commits into from Jun 9, 2020
Merged

fix: add missing isComposing KeyboardEvent property #24015

merged 2 commits into from Jun 9, 2020

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Jun 8, 2020

Description of Change

Manually backport #23971 to 8-x-y. See that PR for details.

CC @electron/wg-releases @codebytere

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
  • PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
  • This is NOT A BREAKING CHANGE. Breaking changes may not be merged to master until 11-x-y is branched.

Release Notes

Notes: Add missing support for isComposing KeyboardEvent property.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 8, 2020
@trop trop bot mentioned this pull request Jun 8, 2020
Merged
6 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Jun 8, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 8, 2020
@codebytere codebytere merged commit 27c1fc8 into 8-x-y Jun 9, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 9, 2020

Release Notes Persisted

Add missing support for isComposing KeyboardEvent property.

@codebytere codebytere deleted the backport/8-x-y/23971-support-is-composing branch June 9, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ckerr @codebytere