Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing isComposing KeyboardEvent property #23971

Merged
merged 1 commit into from Jun 5, 2020

Conversation

codebytere
Copy link
Member

Description of Change

Closes #23244.

We support all standard KeyboardEvent properties, but seem to have forgotten to support isComposing, which was added in Chrome 56. We should do so to maintain parity.

cc @MarshallOfSound @zcbenz @jkleinsc

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
  • PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
  • This is NOT A BREAKING CHANGE. Breaking changes may not be merged to master until 11-x-y is branched.

Release Notes

Notes: Add missing support for isComposing KeyboardEvent property.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 4, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 5, 2020
@codebytere codebytere merged commit 27d629a into master Jun 5, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 5, 2020

Release Notes Persisted

Add missing support for isComposing KeyboardEvent property.

@codebytere codebytere deleted the support-is-composing branch June 5, 2020 22:18
@trop
Copy link
Contributor

trop bot commented Jun 5, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jun 5, 2020

I have automatically backported this PR to "10-x-y", please check out #23995

@trop
Copy link
Contributor

trop bot commented Jun 5, 2020

I have automatically backported this PR to "9-x-y", please check out #23996

@trop
Copy link
Contributor

trop bot commented Jun 8, 2020

@ckerr has manually backported this PR to "8-x-y", please check out #24015

sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'before-input-event' is missing the isComposing property
3 participants