Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove JS for non-native extensions shim #23340

Merged
merged 1 commit into from Apr 30, 2020
Merged

refactor: remove JS for non-native extensions shim #23340

merged 1 commit into from Apr 30, 2020

Conversation

nornagon
Copy link
Member

Description of Change

This removes JS code that is unused now that we've had native-//extensions on for a while.

Ref #19447.

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 29, 2020
@nornagon nornagon mentioned this pull request Apr 29, 2020
Closed
11 tasks
@MarshallOfSound MarshallOfSound merged commit 8d0a612 into master Apr 30, 2020
@release-clerk
Copy link

release-clerk bot commented Apr 30, 2020

No Release Notes

@MarshallOfSound MarshallOfSound deleted the only-native-extensions branch April 30, 2020 16:38
@miniak miniak mentioned this pull request Apr 30, 2020
Merged
3 tasks
@mcous mcous mentioned this pull request May 4, 2020
Closed
3 tasks
@samuelmaddock samuelmaddock mentioned this pull request Sep 6, 2020
Merged
4 tasks
@samuelmaddock samuelmaddock mentioned this pull request Feb 1, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nornagon @zcbenz @MarshallOfSound