Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(extensions): remove old renderer code #25347

Merged

Conversation

samuelmaddock
Copy link
Member

@samuelmaddock samuelmaddock commented Sep 6, 2020

Description of Change

Remove old renderer code used for JavaScript-based Chrome extensions.

The affected files were removed from the bundle in #23340, but never deleted.

Ref #19447

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Sep 6, 2020
@zcbenz zcbenz merged commit 860e14c into electron:master Sep 8, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 8, 2020

No Release Notes

@samuelmaddock samuelmaddock deleted the chore/remove-old-extension-code branch September 21, 2020 04:08
@miniak
Copy link
Contributor

miniak commented Nov 10, 2020

/trop run backport-to 10-x-y

@trop
Copy link
Contributor

trop bot commented Nov 10, 2020

The backport process for this PR has been manually initiated -
sending your commits to "10-x-y"!

@miniak
Copy link
Contributor

miniak commented Nov 10, 2020

/trop run backport-to 11-x-y

@trop
Copy link
Contributor

trop bot commented Nov 10, 2020

The backport process for this PR has been manually initiated -
sending your commits to "11-x-y"!

@trop
Copy link
Contributor

trop bot commented Nov 10, 2020

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Nov 10, 2020

I have automatically backported this PR to "11-x-y", please check out #26441

@nornagon
Copy link
Member

@miniak Why backport this? it's just a cleanup, I don't think it's doing any harm in older branches.

@miniak
Copy link
Contributor

miniak commented Nov 10, 2020

@nornagon I ran into those dangling files when back-porting the IPC change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants